[PATCH] D56175: [PowerPC] Exploit store instructions that store a single vector element

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 07:58:06 PST 2019


jsji added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:3343
+      def : Pat<(store (i64 (extractelt v2i64:$A, 0)), xaddr:$src),
+                (XFSTOREf64 (EXTRACT_SUBREG (XXPERMDI $A, $A, 2),
+                             sub_64), xaddr:$src)>;
----------------
nemanjai wrote:
> jsji wrote:
> > These are identical to little endian patterns above?
> Oops. The extract indices were supposed to be reversed. Good catch. Thank you.
Thanks for updating! One question to me is why this not exposed by testcases below? Are we missing some coverage there?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56175/new/

https://reviews.llvm.org/D56175





More information about the llvm-commits mailing list