[PATCH] D55763: [Sparc] Add Sparc V8 support

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 06:39:26 PST 2019


mgorny added inline comments.


================
Comment at: src/DwarfParser.hpp:684
+#if defined(_LIBUNWIND_TARGET_AARCH64) || defined(_LIBUNWIND_TARGET_SPARC)
+    // The same constant is used to represent different instructions on
+    // AArch64 (negate_ra_state) and SPARC (window_save).
----------------
Could you add a `static_assert` that verifies that the constants indeed have the same value?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55763/new/

https://reviews.llvm.org/D55763





More information about the llvm-commits mailing list