[PATCH] D56570: [llvm-objcopy] Use SHT_NOTE for added note sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 01:55:55 PST 2019


jhenderson added a comment.

I think this is probably okay, but I'm not 100% convinced. Is it possible to force the type of a section called ".note..." to something other than SHT_NOTE? I'm not sure if there's really a use case for this beyond testing though, so it's probably fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56570/new/

https://reviews.llvm.org/D56570





More information about the llvm-commits mailing list