[PATCH] D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument.

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 19:35:07 PST 2019


whitequark requested changes to this revision.
whitequark added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/IR/Core.cpp:3600
+                            LLVMValueRef *Args, unsigned NumArgs,
+                            const char *Name) {
+  FunctionType *FTy = unwrap<FunctionType>(Ty);
----------------
Please add `NameLen` as this is the convention for all new C APIs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56556/new/

https://reviews.llvm.org/D56556





More information about the llvm-commits mailing list