[PATCH] D56573: Remove TypeBuilder.h, and fix the few locations using it.

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 18:34:02 PST 2019


jyknight created this revision.
jyknight added a reviewer: niravd.
Herald added a subscriber: mgorny.

This shortcut mechanism for creating types was added 10 years ago, but
has seen almost no uptake since then, neither internally nor in
external projects.

The very small number of characters saved by using it does not seem
worth the mental overhead of an additional type-creation API, so,
delete it.


https://reviews.llvm.org/D56573

Files:
  llvm/docs/ExtendingLLVM.rst
  llvm/docs/ProgrammersManual.rst
  llvm/include/llvm/IR/TypeBuilder.h
  llvm/tools/lli/lli.cpp
  llvm/unittests/ExecutionEngine/MCJIT/MCJITMultipleModuleTest.cpp
  llvm/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp
  llvm/unittests/ExecutionEngine/MCJIT/MCJITTestBase.h
  llvm/unittests/ExecutionEngine/Orc/IndirectionUtilsTest.cpp
  llvm/unittests/ExecutionEngine/Orc/LegacyRTDyldObjectLinkingLayerTest.cpp
  llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp
  llvm/unittests/ExecutionEngine/Orc/OrcTestCommon.h
  llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
  llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
  llvm/unittests/IR/CFGBuilder.cpp
  llvm/unittests/IR/CMakeLists.txt
  llvm/unittests/IR/TypeBuilderTest.cpp
  llvm/utils/gn/secondary/llvm/unittests/IR/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56573.181202.patch
Type: text/x-patch
Size: 53158 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190111/b8d1bdf3/attachment-0001.bin>


More information about the llvm-commits mailing list