[PATCH] D56567: [ADT] Force attribute used on functions marked as always_inline.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

In D56567#1353607 <https://reviews.llvm.org/D56567#1353607>, @chandlerc wrote:

> I honestly still think this is a poor alternative. I much prefer optimized tablegen if it matters. I'd much prefer defaulting to that in non-release builds as well. I think we should be using fewer attributes to manually hijack the optimizer and instead simply let the optimizer do its job when it is needed. =/


There's no optimizer here as this is, by definition, unoptimized code.
I tend to share your feelings here about the fact that slapping bajillion attributes on functions isn't great.
I don't have any strong preferences (I just care about evaluating expression in the debugger :), I'm just mostly worried that the slowdown might be unacceptable for people. But I assume we can always re-evaluate this later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56567/new/

https://reviews.llvm.org/D56567