[PATCH] D56549: Add support for prefix-only CLI options

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 11:13:14 PST 2019


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

Nice work on the prefix tests.  One comment nit and LGTM.



================
Comment at: llvm/lib/Support/CommandLine.cpp:547
     if (!Value.data()) { // No value specified?
-      if (i + 1 >= argc)
+      // If no other argument or option only support prefix form, we cannot
+      // look at next argument.
----------------
... or the option only supports ...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56549/new/

https://reviews.llvm.org/D56549





More information about the llvm-commits mailing list