[PATCH] D56535: Support MSP430

[Michael Skvortsov via Phabricator via llvm-commits]

mskvortsov added a comment.

> After reading this patch, I decided to *not* roll back this patch as the patch seems acceptable with a few changes (I'm going to make the changes), but please keep in mind that that handling is exceptional; when someone added a new target in such a way like this, we'd normally have to revert it no matter what the patch is, as it is a violation of the usual review process. And I believe you didn't really have to rush to submit; this is a good patch, so just relax and wait for a little for others to review it as well.

Yeah, sorry, probably I just shouldn't have asked to submit that soon.



================
Comment at: lld/trunk/ELF/Arch/MSP430.cpp:45
+  // mov.b #0, r3
+  TrapInstr = {0x43, 0x43};
+}
----------------
ruiu wrote:
> ruiu wrote:
> > TrapInstr must be 4 bytes long. Otherwise it would create a garbage on every two bytes.
> Does this instruction actually triggers a CPU interrupt?
It does trigger an interrupt on a simulator and presumably it does not on a real hardware.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56535/new/

https://reviews.llvm.org/D56535