[PATCH] D56541: Fix FileCheck tests when `FILECHECK_DUMP_INPUT_ON_FAILURE` is set in the environment that llvm-lit is executed in.

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

I've been wanting to fix this too.  Thanks for working on it.  A few issues:

- `FILECHECK_OPTS` should be cleared too.

- The last time I checked (but it's been a little while), the lit test suite had problems with these variables too.

- This approach makes these environment variables unhelpful for this test suite, but they don't have to be.  I think a better solution is to create a command, perhaps a lit substitution named FileCheckee, that clears these environment variables and then calls FileCheck.  Throughout this test suite, any FileCheck call under test would be replaced with FileCheckee.  Other FileCheck calls, whose job is to verify correct output from FileCheckee or from other commands, would still be affected by these environment variables.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56541/new/

https://reviews.llvm.org/D56541