[PATCH] D56270: [DAGCombiner] Allow target to control combine with illegal types.

Alon Kom via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 05:16:03 PST 2019


alonkom added a comment.

In D56270#1352596 <https://reviews.llvm.org/D56270#1352596>, @craig.topper wrote:

> How do you get your target to be able to type legalize an abs of any type? The interface for enabling custom legalization requires calling setOperation with a specific type does it not?


What I meant was that we use the combined abs only in very specific scenarios and with specific types (some are illegal), and combine it to some other target specific node.
Actually, we don't use custom type legalization for the abs, so we will get an error if the abs has an illegal type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56270/new/

https://reviews.llvm.org/D56270





More information about the llvm-commits mailing list