[PATCH] D56506: [X86][SSE] Allow SplitOpsAndApply to split to lowest common vector size

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 19:50:19 PST 2019


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:37004
   if (!((ScalarVT == MVT::i8 || ScalarVT == MVT::i16) &&
-        NumElems >= 2 && isPowerOf2_32(NumElems)))
+        NumElems >= 2 && ((NumElems % 8) == 0 || isPowerOf2_32(NumElems))))
     return SDValue();
----------------
This crashes on v24i8. Probably need InVT.getSizeInBits() % 128 == 0 instead of NumElems % 8 == 0


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56506/new/

https://reviews.llvm.org/D56506





More information about the llvm-commits mailing list