[PATCH] D48404: Don't modify LibFuncs in DeadArgumentElimination or ArgumentPromotion

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Just ran across this again. @jgravelle-google is this still relevant?



================
Comment at: lib/Transforms/IPO/ArgumentPromotion.cpp:831-832
 
+  // Don't promote arguments for library functions. We can make assumptions
+  // about library function signatures in later passes.
+  LibFunc LF;
----------------
lebedev.ri wrote:
> This reads weird.
> Are you sure you didn't mean:
> ```
> // Don't promote arguments for library functions,
> // because later passes may make assumptions about library function signatures.
> ```
+1, this is better wording (and is the intent for this change).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48404/new/

https://reviews.llvm.org/D48404