[lld] r350681 - [ARM][AArch64] Increase TLS alignment to reserve space for Android's TCB

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 15:35:11 PST 2019


This is actually in line with the discussion in
https://reviews.llvm.org/D56396. What we were trying to avoid in this
patch is to add `if (Android)`.

On Wed, Jan 9, 2019 at 5:42 AM Joerg Sonnenberger via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> On Wed, Jan 09, 2019 at 12:09:59AM -0000, Ryan Prichard via llvm-commits wrote:
> > To reconcile this disagreement about TLS memory layout, set the minimum
> > alignment for executable TLS segments to 8 words on ARM/AArch64, which
> > reserves at least 8 words of memory after the TP (2 for the ABI-specified
> > TCB and 6 for alignment padding). For simplicity, and because lld doesn't
> > know when it's targeting Android, increase the alignment regardless of
> > operating system.
>
> I find this commit somewhat ironic given the discussion in D56215...
>
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list