[PATCH] D56396: [LLD][ELF] Fix ARM and Thumb V7PILongThunk overflow behavior.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: test/ELF/arm-extreme-range-pi-thunk.s:3-7
+// RUN: echo "SECTIONS { \
+// RUN:       . = SIZEOF_HEADERS; \
+// RUN:       .text_low : { *(.text) } \
+// RUN:       .text_high 0xf0000000 : { *(.text_high) } \
+// RUN:       } " > %t.script
----------------
nit: I prefer to use multiple `echo` commands instead of using line concatenation, because with line concatenation all lines are concatenated to a single very long line, and if something goes wrong, this test would print out a very long line to the terminal.

Thus, I usually do something like this:

  echo "SECTIONS {" > %t.script
  echo "  . = SIZEOF_HEADERS;" >> %t.script
  ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56396/new/

https://reviews.llvm.org/D56396