[PATCH] D56501: [WebAssembly] Add unimplemented-simd128 subtarget feature

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

In D56501#1351823 <https://reviews.llvm.org/D56501#1351823>, @aheejin wrote:

> (We talked in person and decided not to make simd feature depend on signext)
>
> Nice! Can we have a comment on the code why we are doing that? Basically what we've talked about - SIMD implementation needs `signext_inreg` for clean implementation but that doesn't mean we require signext feature to enable simd feature, so we are doing this... something like that
>
> And I think we should revert the test changes now?


Good idea about the comment. The changes to the test should actually stay because the new test results are the better code that is produced when the sext_inreg node is matched on.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56501/new/

https://reviews.llvm.org/D56501