[PATCH] D56475: Don't require a null terminator when loading objects

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 12:50:21 PST 2019


zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

Thanks.  I fixed this exact bug in a different place <https://github.com/llvm-mirror/llvm/commit/bd238eb6685f0116ba5bf5a113a20ba9e9728241#diff-1c8aa3fe93e000dcfe2f23c583a02fa9> a month ago.  I wonder if we should audit all callers of `getFileOrSTDIN` and `MemoryBuffer::getFile`, because I'm guessing this can still occur in other places for the same reason.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56475/new/

https://reviews.llvm.org/D56475





More information about the llvm-commits mailing list