[PATCH] D56499: refactor BlockFrequencyInfo::view to take a title parameter

David Callahan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 09:24:16 PST 2019


david2050 created this revision.
david2050 added reviewers: twoh, Kader, modocache.
Herald added a subscriber: llvm-commits.

All a non-default title for the debugging this debugging aide


Repository:
  rL LLVM

https://reviews.llvm.org/D56499

Files:
  include/llvm/Analysis/BlockFrequencyInfo.h
  lib/Analysis/BlockFrequencyInfo.cpp


Index: lib/Analysis/BlockFrequencyInfo.cpp
===================================================================
--- lib/Analysis/BlockFrequencyInfo.cpp
+++ lib/Analysis/BlockFrequencyInfo.cpp
@@ -252,8 +252,8 @@
 
 /// Pop up a ghostview window with the current block frequency propagation
 /// rendered using dot.
-void BlockFrequencyInfo::view() const {
-  ViewGraph(const_cast<BlockFrequencyInfo *>(this), "BlockFrequencyDAGs");
+void BlockFrequencyInfo::view(StringRef title) const {
+  ViewGraph(const_cast<BlockFrequencyInfo *>(this), title);
 }
 
 const Function *BlockFrequencyInfo::getFunction() const {
Index: include/llvm/Analysis/BlockFrequencyInfo.h
===================================================================
--- include/llvm/Analysis/BlockFrequencyInfo.h
+++ include/llvm/Analysis/BlockFrequencyInfo.h
@@ -56,7 +56,7 @@
 
   const Function *getFunction() const;
   const BranchProbabilityInfo *getBPI() const;
-  void view() const;
+  void view(StringRef = "BlockFrequencyDAGs") const;
 
   /// getblockFreq - Return block frequency. Return 0 if we don't have the
   /// information. Please note that initial frequency is equal to ENTRY_FREQ. It


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56499.180863.patch
Type: text/x-patch
Size: 1168 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190109/da34ed1e/attachment.bin>


More information about the llvm-commits mailing list