[PATCH] D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files"

[Lama via Phabricator via llvm-commits]

lsaba added a comment.

In D56084#1350146 <https://reviews.llvm.org/D56084#1350146>, @aprantl wrote:

> Hmmm.. my fix didn't go far enough. I  reverted this patch once again, so we can sort this out without pressure. As long as you make sure that compiling with -DLLVM_ENABLE_MODULES=1 works, feel free to recommit at any




In D56084#1350528 <https://reviews.llvm.org/D56084#1350528>, @aprantl wrote:

> It should not be mac-specific, but it is possible that Linux uses a different default for LLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY. Can you try again with `-DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0  -DLLVM_ENABLE_MODULES=1` ?


I tried to build with the suggested flags but I got unrelated errors on top of trunk without my commits. 
The way i'm compiling and building is this:

first build: cmake '-G' 'Ninja' ../../llvm '-DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE' '-DCMAKE_BUILD_TYPE=Release' 
(This uses GNU 5.4 compiler to build)

second build: cmake '-G' 'Ninja' ../../llvm '-DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE' '-DCMAKE_BUILD_TYPE=Release' '-DLLVM_VERSION_PATCH=99' '-DLLVM_ENABLE_MODULES=1' -DCMAKE_C_COMPILER=/firstbuild/bin/clang  -DCMAKE_CXX_COMPILER=/firstbuild/bin/clang++ -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0

without the second flag -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0 I don't get errors when building with my patch.. Am i missing something with the compilation flags?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56084/new/

https://reviews.llvm.org/D56084