[PATCH] D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator.

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 01:59:05 PST 2019


kristina marked 2 inline comments as done.
kristina added inline comments.


================
Comment at: docs/Phabricator.rst:34
+
+* As a general rule, please make sure that abandoned revisions are marked as
+  such and that once a revision is committed it is closed. The easiest way as
----------------
I think this point needs to be rewritten, main emphasis being on not leaving "stray" revisions behind at which point it's hard to tell if they've been committed but not linked or abandoned etc.


================
Comment at: docs/Phabricator.rst:63
+  pre-commit review.
+* Significant patches that affect multiple components (for example if you need
+  a patch for LLVMSupport followed by a patch to Clang's CodeGen), it may be
----------------
For significant*


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56482/new/

https://reviews.llvm.org/D56482





More information about the llvm-commits mailing list