[PATCH] D54769: [FileCheck] New option -warn

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D54769#1317228 <https://reviews.llvm.org/D54769#1317228>, @jdenny wrote:

> Another problem would be if lit substitutions make FileCheck commands or their prefixes unrecognizable.  I haven't looked for that usage yet.


I can't imagine that being a real thing. `FileCheck` itself is a token that lit substitutes just to paste the tools directory onto it while building the actual command lines. Lit substitutions in prefix names... makes no sense.

>> Yeah, I'd suggest scratching something simple up with grep/sed/python/whatever to get a sense of the magnitude of the problem before sinking time into trying to design/build a long-term solution. My feeling is still that this isn't a problem worth solving given the complexity of the solutions thus far (the self-checking FileCheck version (despite its duplicate error messages, etc) feels like the cheapest I can think of & still isn't terribly nice, I think) - but data will help.
> 
> Agreed.  No promises I'll do this anytime soon.  I just want to see if people feel that, if this mistyped/unused directive problem is actually worth addressing, this approach is the right one.

I don't doubt there are some, and developing a script/utility to find them could be helpful.  But automating that process... my guess is, unlikely to be worthwhile unless new cases are being added frequently, which I would not expect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769