[PATCH] D56419: [gn build] Move .gn file to the root of the monorepo

David Major via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 15:13:13 PST 2019


dmajor added a comment.

In D56419#1349948 <https://reviews.llvm.org/D56419#1349948>, @thakis wrote:

> I'd be interested in feedback from more people if anyone has any (e.g. "don't care").


I assume that nobody wants the GN build support out of a purely abstract interest or a desire to just play around with it once. Presumably, people (myself included) want to actually use it day to day, no matter how many times it says unofficial and unsupported. I don't think this can be avoided with disclaimers alone.

I can definitely understand how this would be cause for concern among people who don't want to see a parallel build system in the project. And I can definitely understand how elevating the GN support to a more official-looking and enticing place at the root of the tree would make the feeling worse. Holding off on this sounds like the right thing to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56419/new/

https://reviews.llvm.org/D56419





More information about the llvm-commits mailing list