[PATCH] D55769: Add support for demangling msvc's noexcept types to llvm-undname

Kristina Brooks via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 12:49:14 PST 2019


Alright, will hold off in that case.

Thanks.

On 08/01/2019 19:50, Zachary Turner wrote:
> I'll do it, I was on vacation for the past 3 weeks, sorry about that!
> 
> On Tue, Jan 8, 2019 at 11:40 AM Kristina Brooks via Phabricator <reviews at reviews.llvm.org
> <mailto:reviews at reviews.llvm.org>> wrote:
> 
>     kristina added a comment.
> 
>     In D55769#1350029 <https://reviews.llvm.org/D55769#1350029>, @zahen wrote:
> 
>     > In D55769#1333778 <https://reviews.llvm.org/D55769#1333778>, @zturner wrote:
>     >
>     > > lgtm.  I'm technically on vacation so rnk@ might be able to commit it sooner than I can, but if he doesn't, then
>     I'll commit it when I find some spare cycles.  Thanks for fixing this!
>     >
>     >
>     > Hi @zturner, can you please commit this when you have a chance?
> 
> 
>     I don't mind doing it if there are no objections, as Zachary has signed off on it (may have to wait a bit, I'll run
>     the tests with this applied first).
> 
> 
>     Repository:
>       rL LLVM
> 
>     CHANGES SINCE LAST ACTION
>       https://reviews.llvm.org/D55769/new/
> 
>     https://reviews.llvm.org/D55769
> 
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3992 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/737d34b6/attachment.bin>


More information about the llvm-commits mailing list