[PATCH] D56287: [X86] Fix incomplete handling of register-assigned variables in parsing.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 11:19:44 PST 2019


niravd added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2061
+          return nullptr;
+        assert(!isa<X86MCExpr>(Imm) &&
+               "Expected non-register to be parsed here.");
----------------
jyknight wrote:
> Is this guaranteed to be true?
Yes. The previous peekidentifier should return true if it was a register. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56287/new/

https://reviews.llvm.org/D56287





More information about the llvm-commits mailing list