[PATCH] D51206: [Sparc] Add tail call support

[James Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: lib/Target/Sparc/SparcISelLowering.cpp:733
+  // a struct and the other does not.
+  if (!Outs.empty() && Caller.hasStructRetAttr() != Outs[0].Flags.isSRet())
+    return false;
----------------
Whilst correct for now given the 64-bit lowering does not support tail calls, this condition only applies to the 32-bit SPARC ABI, as the 64-bit ABI does not have the extra `unimp` after the delay slot for struct-returning functions. Perhaps worth adding a comment here so this doesn't get forgotten?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51206/new/

https://reviews.llvm.org/D51206