[PATCH] D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated.

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 07:58:04 PST 2019


dstenb added a comment.

This looks good to me, but I don't think I can give an official L-G-T-M.

Have you addressed all of the reviewers' comments?



================
Comment at: test/CodeGen/Generic/live-debug-label.ll:35
+;
+; RUN: llc < %s -stop-after=virtregrewriter -o - | FileCheck %s
+;
----------------
In general I think it is preferred to have the `RUN:` lines at the top of the file.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54465/new/

https://reviews.llvm.org/D54465





More information about the llvm-commits mailing list