[PATCH] D56436: [SelectionDAG][RFC] Allow the user to specify a memeq function (v4).

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 06:23:29 PST 2019


courbet created this revision.
Herald added a subscriber: fedor.sergeev.

Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.

This is sub-optimal because memcmp has to compute much more than
equality.

This patch uses `bcmp()` on platforms that support it.

This function will be called instead of `memcmp()` when the result of the memcmp
call is only used for equality comparison.

`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.


Repository:
  rL LLVM

https://reviews.llvm.org/D56436

Files:
  include/llvm/IR/RuntimeLibcalls.def
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/TargetLoweringBase.cpp
  test/CodeGen/X86/memcmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56436.180652.patch
Type: text/x-patch
Size: 13401 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/fba298ab/attachment-0001.bin>


More information about the llvm-commits mailing list