[PATCH] D56386: [DA][NewPM] Add a printerpass and port the testsuite

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 05:38:58 PST 2019


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of minor points.



================
Comment at: llvm/include/llvm/Analysis/DependenceAnalysis.h:948
+    raw_ostream &OS;
+  }; // class DependenceAnalysis
+
----------------
class DependenceAnalysisPrinterPass


================
Comment at: llvm/lib/Passes/PassRegistry.def:214
 FUNCTION_PASS("print<stack-safety-local>", StackSafetyPrinterPass(dbgs()))
+FUNCTION_PASS("print<da>", DependenceAnalysisPrinterPass(dbgs()))
 FUNCTION_PASS("reassociate", ReassociatePass())
----------------
These look like they should be in alphabetical ordering


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56386/new/

https://reviews.llvm.org/D56386





More information about the llvm-commits mailing list