[PATCH] D56244: [XRay][docs] XRay Framework Usage Guide

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: llvm/docs/XRayFramework.rst:396
+    if (finalized.exchange(1, std::memory_order_acq_rel) == 1)
+      XRayLogInitStatus::XRAY_LOG_FINALIZED;
+
----------------
greened wrote:
> What is this doing?
Updated with a comment.


================
Comment at: llvm/docs/XRayFramework.rst:423
+    // pointer so that it can be treated as a global variable by the lambda we
+    // provide to the call to __xray_log_process_buffers(...).
+    static FILE* tmpf = 0;
----------------
greened wrote:
> I don't understand this comment.
Updated it to explain that the function-local *static* pointer is accessible as a global variable in the lambda which may not have captures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56244/new/

https://reviews.llvm.org/D56244