[PATCH] D55639: GlobalISel: Allow shift amount to be a different type

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 17:06:40 PST 2019


arsenm added a comment.

In D55639#1348912 <https://reviews.llvm.org/D55639#1348912>, @aemerson wrote:

> Thanks, this definitely needed to be done. Looks mostly fine, but I also can't be confident on the X86 changes. @igorb @aivchenk can you take a look at this change?


Do you have an opinion how how to handle selecting the shift amount type in the combiner?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55639/new/

https://reviews.llvm.org/D55639





More information about the llvm-commits mailing list