[PATCH] D56419: [gn build] Move .gn file to the root of the monorepo

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 16:37:04 PST 2019


thakis added a comment.

>>   I don't see the downside of adding a hidden file at the toplevel yet.
> 
> The change promotes an unsupported, parallel, build system to the top of LLVM. It's precisely the situation I and others who spoke up on llvm-dev were trying to avoid.

Sorry, I don't see how a hidden file that says "this is unsupported" has much promotional value.

>> I'd like to point out that there's no interest from Google in this.
> 
> So why make the change at all then if so few people are even using gn at all?

Because people asked me for it, mostly. (I'll admit it's also more pleasant for myself to use now that it's upstream, but it was a lot of work to get it upstreamed, so it wouldn't have been worth it just for that.) Now that it's there I'm trying to make it as easy to use as possible, in the hope that that entices more people giving it a try, hence this change. (And why do I bother with that? So that more people hopefully see how needlessly slow the CMake build is, so that folks trying to make the CMake build get less pushback.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56419/new/

https://reviews.llvm.org/D56419





More information about the llvm-commits mailing list