[PATCH] D56419: [gn build] Move .gn file to the root of the monorepo

Mon Jan 7 16:11:30 PST 2019

thakis added a comment.

In D56419#1349014 <https://reviews.llvm.org/D56419#1349014>, @brzycki wrote:

> I am strongly against this commit. @thakis when this was discussed on llvm-dev the original proposal was the compromise of placing .gn in utils to signify that it was not the default, recommended, method to build LLVM.  With this change LLVM will truly have two, parallel build systems once again.

This is not changing. The first line in the added file here is: "# LLVM's GN build is unsupported, see llvm/utils/gn/README.rst for details." Is that not clear enough? I'm happy to repeat that line 100 times and add another 100 lines whitespace to make it more obvious.

I'm done upstreaming the stuff I had and as promised all changes except for one test change (r350416) have been in llvm/utils/gn.

I'd love to have this file at the toplevel. If there's strong pushback, I won't pursue it of course, but I don't see the downside of adding a hidden file at the toplevel yet.

> In my opinion making the invocation of gn less cumbersome for a handful of Google developers

I'd like to point out that there's no interest from Google in this. It is true that I am employed by Google and that I wrote this for my personal use, and that most people I talk to socially about this are at Google, but there's no org interest in this. The participants at the GN roundtable who expressed interest in this were pretty mixed organizationally (maybe 40% Google employees). I'm not sure if this point matters much though.

> does not justify the significance of having two build systems at the top level.
> 
>   git clone monorepo $DIR
>   cd $DIR
>   ln -s utils/.gn

Sure, this works, but it's less convenient. The whole point of having this file here is convenience -- the symlink isn't needed either if you pass in `--dotfile=llvm/utils/gn/.gn --root=. gen`, as the change description mentions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56419/new/

https://reviews.llvm.org/D56419