[PATCH] D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 15:06:46 PST 2019


thakis created this revision.
thakis added a reviewer: phosek.
Herald added subscribers: sunfish, aheejin, mgorny, dschuff.
Herald added a reviewer: serge-sans-paille.

After the PowerPC and WebAssembly targets are added, this check passes.


https://reviews.llvm.org/D56417

Files:
  llvm/utils/gn/build/sync_source_lists_from_cmake.py


Index: llvm/utils/gn/build/sync_source_lists_from_cmake.py
===================================================================
--- llvm/utils/gn/build/sync_source_lists_from_cmake.py
+++ llvm/utils/gn/build/sync_source_lists_from_cmake.py
@@ -61,7 +61,7 @@
     unittest_re = re.compile(r'^add_\S+_unittest', re.MULTILINE)
 
     # FIXME: Add 'llvm' here once it's complete.
-    checked = [ 'clang', 'lld' ]
+    checked = [ 'clang', 'lld', 'llvm' ]
     for c in checked:
         for root, _, _ in os.walk(os.path.join(c, 'unittests')):
             cmake_file = os.path.join(root, 'CMakeLists.txt')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56417.180570.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190107/9067daeb/attachment.bin>


More information about the llvm-commits mailing list