[PATCH] D56412: [WebAssembly] Standardize order of SIMD bitselect arguments

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 14:07:23 PST 2019


tlively created this revision.
tlively added a reviewer: aheejin.
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, sbc100, dschuff.

For some reason the backend assumed that the condition mask would be
the first argument to the LLVM intrinsic, but everywhere else the
condition mask is the third argument.


Repository:
  rL LLVM

https://reviews.llvm.org/D56412

Files:
  lib/Target/WebAssembly/WebAssemblyInstrSIMD.td


Index: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
===================================================================
--- lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
+++ lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
@@ -579,7 +579,7 @@
     SIMD_I<(outs V128:$dst), (ins V128:$v1, V128:$v2, V128:$c), (outs), (ins),
            [(set (vec_t V128:$dst),
              (vec_t (int_wasm_bitselect
-               (vec_t V128:$c), (vec_t V128:$v1), (vec_t V128:$v2)
+               (vec_t V128:$v1), (vec_t V128:$v2), (vec_t V128:$c)
              ))
            )],
            "v128.bitselect\t$dst, $v1, $v2, $c", "v128.bitselect", 80>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56412.180561.patch
Type: text/x-patch
Size: 644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190107/4a4e429f/attachment.bin>


More information about the llvm-commits mailing list