[PATCH] D53945: [TextAPI] TBD Reader/Writer

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 10:05:58 PST 2019


steven_wu added a comment.

In D53945#1347562 <https://reviews.llvm.org/D53945#1347562>, @thakis wrote:

> In D53945#1343312 <https://reviews.llvm.org/D53945#1343312>, @thakis wrote:
>
> > Out of interest, why aren't most of the tests for this lit tests? The usual llvm way of testing stuff is to write a small llvm tool using your library (which will be useful outside of a testing context too) and then use that to write lit tests.
>
>
> Looks like this is now happening (rL350341 <https://reviews.llvm.org/rL350341>). Are most of the unit tests going to move to lit tests now?


This is a different YAML format from r350341 but unittest is running as part of the lit as well, right?
A new tool can be created to read MachO YAML file but I want to understand your real concern here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53945/new/

https://reviews.llvm.org/D53945





More information about the llvm-commits mailing list