[PATCH] D55686: [PowerPC] Fix assert from machine verify pass that unmatched register class about fcmp selection in fast-isel

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 09:42:26 PST 2019


hfinkel accepted this revision.
hfinkel added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/PowerPC/PPCFastISel.cpp:895
+      } else if (isVSSRCRegClass(RC)) {
+        llvm_unreachable("unsupport f32 vsx cmp");
+      } else {
----------------
It's best to write this out : "Unsupposed f32 VSX comparison".

Otherwise, LGTM.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55686/new/

https://reviews.llvm.org/D55686





More information about the llvm-commits mailing list