[PATCH] D56268: [Sanitizer] Intercept fdevname on FreeBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 06:36:03 PST 2019


devnexen marked an inline comment as done.
devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:9369
+  char *name = REAL(fdevname_r)(fd, buf, len);
+  if (buf && len > 0) {
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, buf, REAL(strlen)(buf) + 1);
----------------
devnexen wrote:
> krytarowski wrote:
> > shouldn't we check for `if (name)` ?
> redundant here.
I misread your comment level...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56268/new/

https://reviews.llvm.org/D56268





More information about the llvm-commits mailing list