[PATCH] D56268: [Sanitizer] Intercept fdevname on FreeBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 6 22:56:54 PST 2019


devnexen marked an inline comment as done.
devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:9370
+  if (buf && len > 0) {
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, buf, len);
+    if (fd > 0)
----------------
krytarowski wrote:
> Is the buffer 0-terminated? I think we need to use `REAL(strlen)()` here and write only what was really initialized.
Yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56268/new/

https://reviews.llvm.org/D56268





More information about the llvm-commits mailing list