[PATCH] D56352: GlobalISel: Implement widenScalar for implicit_def

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: t.p.northover, dsanders, aditya_nandakumar, ab.
Herald added subscribers: javed.absar, kristof.beyls, rovka, wdng.

https://reviews.llvm.org/D56352

Files:
  lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  test/CodeGen/AArch64/GlobalISel/legalize-undef.mir


Index: test/CodeGen/AArch64/GlobalISel/legalize-undef.mir
===================================================================
--- test/CodeGen/AArch64/GlobalISel/legalize-undef.mir
+++ test/CodeGen/AArch64/GlobalISel/legalize-undef.mir
@@ -1,5 +1,5 @@
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s
+# RUN: llc -march=aarch64 -run-pass=legalizer -O0 %s -o - | FileCheck %s
 ---
 name:            test_implicit_def
 body: |
@@ -16,3 +16,21 @@
     %1:_(s64) = G_TRUNC %0(s128)
     $x0 = COPY %1(s64)
 ...
+
+---
+name: test_implicit_def_s3
+body: |
+  bb.0:
+    liveins:
+
+    ; CHECK-LABEL: name: test_implicit_def_s3
+    ; CHECK: [[DEF:%[0-9]+]]:_(s8) = G_IMPLICIT_DEF
+    ; CHECK: [[TRUNC:%[0-9]+]]:_(s3) = G_TRUNC [[DEF]](s8)
+    ; CHECK: [[SEXT:%[0-9]+]]:_(s64) = G_SEXT [[TRUNC]](s3)
+    ; CHECK: $x0 = COPY [[SEXT]](s64)
+    %0:_(s3) = G_IMPLICIT_DEF
+    %1:_(s64) = G_SEXT %0
+    $x0 = COPY %1(s64)
+...
+
+# FIXME: s2 not correctly handled
Index: lib/CodeGen/GlobalISel/LegalizerHelper.cpp
===================================================================
--- lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -938,6 +938,12 @@
     Observer.changedInstr(MI);
     return Legalized;
   }
+  case TargetOpcode::G_IMPLICIT_DEF: {
+    Observer.changingInstr(MI);
+    widenScalarDst(MI, WideTy);
+    Observer.changedInstr(MI);
+    return Legalized;
+  }
   case TargetOpcode::G_BRCOND:
     Observer.changingInstr(MI);
     widenScalarSrc(MI, WideTy, 0, TargetOpcode::G_ANYEXT);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56352.180367.patch
Type: text/x-patch
Size: 1644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190105/ca852a7a/attachment.bin>