[PATCH] D56337: [ADT] Remove attribute LLVM_ALWAYS_INLINE from several classes.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 15:58:50 PST 2019


chandlerc added inline comments.


================
Comment at: llvm/docs/TestingGuide.rst:110
 
+In order to get reasonable test performances, build LLVM and subprojects
+with at least ``-O2``, i.e.
----------------
JDevlieghere wrote:
> Should we rephrase this in a way that makes it clear that you don't always have to set the CMake flag, e.g. in release? Maybe something like `build ... in release or at least with -O2"? 
That's a good point, we should instead suggest enabling one of teh release build modes rather than hard coding flags here.

Maybe clarify that those are independent of LLVM_ENABLE_ASSERTIONS.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56337/new/

https://reviews.llvm.org/D56337





More information about the llvm-commits mailing list