[PATCH] D56275: x86 interrupt calling convention: Fix argument offsets
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 4 15:15:36 PST 2019
rnk added a comment.
@phil-opp, sorry for the breakage, I understand your frustration. From my perspective, the x86 interrupt calling convention was hacked into the x86 backed in a way that doesn't play nice with orthogonal features, like the copy elision I added. Your fix proliferates the wrong direction of the existing design of the interrupt convention. Yes, it fixes the problem, but if I don't push back, require a test, contact Intel, the original authors of this feature, and pressure them to do it in a more proper way, LLVM will continue to become more unmaintanable.
I would promise to take responsibility and fix this properly myself, but I am going on vacation next week, and I don't plan to bring a laptop. I hesitate to make promises for freely given open source work with a time horizon beyond a week, but if you ping this in a week and a half, I can try to make a test and proper fix then.
In any case, thanks for the report, I'm aware of the problem now.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56275/new/
https://reviews.llvm.org/D56275
More information about the llvm-commits
mailing list