[PATCH] D56294: [ObjectYAML] [COFF] Support multiple symbols with the same name

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 13:26:44 PST 2019


mstorsjo updated this revision to Diff 180311.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Herald added a subscriber: arphaman.

Added a testcase, applied @jhenderson's suggestions (erroring out if both SymbolName and SymbolTableIndex are present, avoiding touching SymbolTableIndexMap if direct index is set, changed the (misspelled) SymbolOccurrances map into a SymbolUnique map).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56294/new/

https://reviews.llvm.org/D56294

Files:
  include/llvm/ObjectYAML/COFFYAML.h
  lib/ObjectYAML/COFFYAML.cpp
  test/tools/yaml2obj/coff-symbol-index.yaml
  tools/obj2yaml/coff2yaml.cpp
  tools/yaml2obj/yaml2coff.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56294.180311.patch
Type: text/x-patch
Size: 11076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190104/34720430/attachment.bin>


More information about the llvm-commits mailing list