[PATCH] D56327: [PGO] Use SourceFileName rather module name in PGOFuncName

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 12:29:46 PST 2019


davidxl added inline comments.


================
Comment at: lib/ProfileData/InstrProf.cpp:255
   if (!InLTO) {
-    StringRef FileName = (StaticFuncFullModulePrefix
-                              ? F.getParent()->getName()
-                              : sys::path::filename(F.getParent()->getName()));
-    if (StaticFuncFullModulePrefix && StaticFuncStripDirNamePrefix != 0)
-      FileName = stripDirPrefix(FileName, StaticFuncStripDirNamePrefix);
+    StringRef FileName(F.getParent()->getSourceFileName());
+    uint32_t StripLevel = StaticFuncFullModulePrefix ? 0 : -1;
----------------
When StaticFullModulePrefix is false, should the base name be used ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56327/new/

https://reviews.llvm.org/D56327





More information about the llvm-commits mailing list