[PATCH] D56325: Sort symbols in .bss by size.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 11:20:25 PST 2019


pcc added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1249
+  // number of dirty pages at runtime.
+  if (Name == ".bss")
+    Sec->sort([](InputSectionBase *S) { return S->getSize(); });
----------------
I wonder whether we should do this for all `SHF_WRITE` sections. I can see similar logic applying to `.data` for example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56325/new/

https://reviews.llvm.org/D56325





More information about the llvm-commits mailing list