[llvm] r350394 - [gn build] Make write_cmake_config.py check that each key passed is unique

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 05:48:58 PST 2019


Author: nico
Date: Fri Jan  4 05:48:58 2019
New Revision: 350394

URL: http://llvm.org/viewvc/llvm-project?rev=350394&view=rev
Log:
[gn build] Make write_cmake_config.py check that each key passed is unique

I got that wrong once while locally while working on check-llvm.

Reviewed as part of https://reviews.llvm.org/D56195

Modified:
    llvm/trunk/utils/gn/build/write_cmake_config.py

Modified: llvm/trunk/utils/gn/build/write_cmake_config.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/write_cmake_config.py?rev=350394&r1=350393&r2=350394&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/write_cmake_config.py (original)
+++ llvm/trunk/utils/gn/build/write_cmake_config.py Fri Jan  4 05:48:58 2019
@@ -53,6 +53,9 @@ def main():
     values = {}
     for value in args.values:
         key, val = value.split('=', 1)
+        if key in values:
+            print('duplicate key "%s" in args' % key, file=sys.stderr)
+            return 1
         values[key] = val.replace('\\n', '\n')
     unused_values = set(values.keys())
 




More information about the llvm-commits mailing list