[PATCH] D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 03:48:13 PST 2019


jmorse added inline comments.


================
Comment at: lib/CodeGen/MachineCopyPropagation.cpp:250
+      } else {
+        assert(Reader && "Debug reader must specify instruction");
+        CopyDbgUsers[Copy].push_back(Reader);
----------------
aprantl wrote:
> Could we just pass a MachineInstr& instead, or can it be null for the !IsDebug case?
We can indeed, uploading a new version now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56265/new/

https://reviews.llvm.org/D56265





More information about the llvm-commits mailing list