[PATCH] D56297: [DWARFUnit] Don't assume basic types.

[Davide Italiano via Phabricator via llvm-commits]

davide marked an inline comment as done.
davide added a comment.

Yes, the problem is that this is a Subroutine type. We might as well reject this altogether in the verifier, what do you think?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:472
+  if (!BTy)
+    return false;
   unsigned Encoding = BTy->getEncoding();
----------------
aprantl wrote:
> Why is false the right answer here?
To be quite honest, I think it's irrelevant (in the sense that it doesn't matter what we return here).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56297/new/

https://reviews.llvm.org/D56297