[PATCH] D56239: [hwasan] Switch to 64 allocator with a dense size class map.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 3 15:20:21 PST 2019
eugenis marked an inline comment as done.
eugenis added inline comments.
================
Comment at: compiler-rt/test/hwasan/TestCases/heap-buffer-overflow.c:46
//
-// CHECKm30: allocated heap chunk; size: 32 offset: 2
// CHECKm30: is located 30 bytes to the left of 30-byte region
----------------
@kcc btw these checks rely on the fact that this allocation is not the first in its size class. This assumption can be broken even w/o llvm/compiler-rt code changes - ex. by a change in libc startup code.
Not sure what to do about this. Maybe we should also describe the chunk that we think is the source of the overflow (that would be an improvement regardless) and test for that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56239/new/
https://reviews.llvm.org/D56239
More information about the llvm-commits
mailing list