[PATCH] D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

In D56284#1345811 <https://reviews.llvm.org/D56284#1345811>, @anna wrote:

> In D56284#1345766 <https://reviews.llvm.org/D56284#1345766>, @kuhar wrote:
>
> > @anna Can this be rewritten to use the DomTreeUpdater utility?
>
>
> @kuhar, I have not looked at the DTU uttility yet, but I'd think it can be rewritten (unless there are some limitations for the DomTreeUpdater utility). However, that would be a large enough change and I think it's better to do it as a separate change at a later point rather than as part of fixing this bug. Also, there are enough DT updates through out this code that it will take a while to get through the whole process of porting over for runtime unrolling.


I see, thank you for the explanation. I think think there's nothing stopping it from being ported, this will be the correct long-term fix. I skimmed through the code and it shouldn't take more than a day. But as you mentioned, it can happen in a separate patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56284/new/

https://reviews.llvm.org/D56284