[PATCH] D55940: Detect incorrect FileCheck variable CLI definition

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Changes to CommandLine.* should be tested in llvm/unittests/Support/CommandLineTest.cpp, as a rule. We don't want to rely on FileCheck tests to verify code in Support.



================
Comment at: llvm/lib/Support/CommandLine.cpp:430
   // If the argument before the = is a valid option name, we match.  If not,
   // return Arg unmolested.
   auto I = Sub.OptionsMap.find(Arg.substr(0, EqualPos));
----------------
You've made this comment incorrect now, please update.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55940/new/

https://reviews.llvm.org/D55940