[PATCH] D56257: Python compat - iteritems

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 06:17:06 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL350312: Python compat - iteritems() vs. items() (authored by serge_sans_paille, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D56257?vs=180020&id=180057#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56257/new/

https://reviews.llvm.org/D56257

Files:
  llvm/trunk/test/tools/llvm-readobj/Inputs/relocs.py
  llvm/trunk/utils/Reviewing/find_interesting_reviews.py
  llvm/trunk/utils/docker/scripts/llvm_checksum/llvm_checksum.py


Index: llvm/trunk/utils/docker/scripts/llvm_checksum/llvm_checksum.py
===================================================================
--- llvm/trunk/utils/docker/scripts/llvm_checksum/llvm_checksum.py
+++ llvm/trunk/utils/docker/scripts/llvm_checksum/llvm_checksum.py
@@ -183,7 +183,7 @@
     if len(new_checksums) != len(reference_checksums):
       return False
 
-  for proj, checksum in new_checksums.iteritems():
+  for proj, checksum in new_checksums.items():
     # We never computed a checksum for this project.
     if proj not in reference_checksums:
       return False
Index: llvm/trunk/utils/Reviewing/find_interesting_reviews.py
===================================================================
--- llvm/trunk/utils/Reviewing/find_interesting_reviews.py
+++ llvm/trunk/utils/Reviewing/find_interesting_reviews.py
@@ -52,10 +52,10 @@
         return self.id2PhabObjects[id]
 
     def get_ids_in_cache(self):
-        return self.id2PhabObjects.keys()
+        return list(self.id2PhabObjects.keys())
 
     def get_objects(self):
-        return self.id2PhabObjects.values()
+        return list(self.id2PhabObjects.values())
 
     DEFAULT_DIRECTORY = "PhabObjectCache"
 
Index: llvm/trunk/test/tools/llvm-readobj/Inputs/relocs.py
===================================================================
--- llvm/trunk/test/tools/llvm-readobj/Inputs/relocs.py
+++ llvm/trunk/test/tools/llvm-readobj/Inputs/relocs.py
@@ -75,7 +75,7 @@
     def makeKey(item):
       return (item[1], item[0])
     e = []
-    for pair in sorted(self._nameMap.iteritems(), key=makeKey):
+    for pair in sorted(self._nameMap.items(), key=makeKey):
       e.append(pair)
     return e
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56257.180057.patch
Type: text/x-patch
Size: 1683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190103/3a04b8d8/attachment-0001.bin>


More information about the llvm-commits mailing list